Update fetch tool to use metis #1192
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the GitHub repository tool to use the "metis" service by refactoring the GithubAvailableEmbeddingTypesManager into a proper dependency injection service pattern. The change introduces a service interface and registers it with the DI container to improve code organization and testability.
Key changes:
- Converts
GithubAvailableEmbeddingTypesManagerto a proper service with interface - Updates all consumers to use dependency injection instead of manual instantiation
- Adds proper service registration in both production and test environments
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/platform/workspaceChunkSearch/common/githubAvailableEmbeddingTypes.ts | Creates service interface and renames class to follow service pattern |
| src/platform/workspaceChunkSearch/node/workspaceChunkSearchService.ts | Updates to use injected service instead of manual instantiation |
| src/platform/urlChunkSearch/node/urlChunkEmbeddingsIndex.ts | Adds service injection and updates embedding computation calls |
| src/platform/embeddings/common/embeddingsComputer.ts | Extracts EmbeddingInputType to a named type |
| src/extension/tools/node/githubRepoTool.tsx | Updates to use injected service instead of lazy instantiation |
| src/extension/extension/vscode-node/services.ts | Registers the new service in the DI container |
| test/base/simulationContext.ts | Adds service registration for test environment |
| @IRunCommandExecutionService _commandService: IRunCommandExecutionService, | ||
| @IInstantiationService private readonly _instantiationService: IInstantiationService, | ||
| @IGithubCodeSearchService private readonly _githubCodeSearch: IGithubCodeSearchService, | ||
| @IGithubAvailableEmbeddingTypesService private readonly _availableEmbeddingTypesManager: Lazy<GithubAvailableEmbeddingTypesService>, |
There was a problem hiding this comment.
The parameter type annotation is incorrect. It should be IGithubAvailableEmbeddingTypesService not Lazy<GithubAvailableEmbeddingTypesService> since the service is now injected directly through DI rather than being lazy-loaded.
Copilot uses AI. Check for mistakes.
There was a problem hiding this comment.
@mjbvz yeah, actually this is interesting. Intentional?
|
If the changes appear safe, you can manually trigger the pipeline by commenting |
|
If the changes appear safe, you can manually trigger the pipeline by commenting |
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
* Update fetch tool to use metis microsoft/vscode#268956 * Add service dep for tests to * Use mock service for tests * Fix lazy
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Fixes microsoft/vscode#268956